Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (dev-server-rollup): support child plugins in resolution algorithm #2050

Merged
merged 5 commits into from
Feb 16, 2023
Merged

fix (dev-server-rollup): support child plugins in resolution algorithm #2050

merged 5 commits into from
Feb 16, 2023

Commits on Jan 18, 2023

  1. fix (dev-server-rollup): support child plugins in resolution algorithm 

    It is possible a rollup plug injects its own child plugins by hooking
into the rollup `options` hook and mutating the options to have extra
plugs.

This change introduces a check for such plugins and calls them before
the host plugin in case they successfully resolve a path first.

Similarly, the `resolve` method of plugins receives an options object to
hold state for the resolution plugins. We currently lose this object
when calling through to `resolveImport`, which can confuse third-party
plugins/resolvers heavily.

To fix this, `resolveImport` now also accepts a `resolverOptions` so we
can pass it on when calling child plugins.
    @43081j
    43081j committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    742cce8 View commit details
    Browse the repository at this point in the history

  2. fix (dev-server-rollup): respect skipSelf

    @43081j
    43081j committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    0248872 View commit details
    Browse the repository at this point in the history

  3. fix (dev-server-rollup): fix ImportSkip map order

    @lucaelin @43081j
    lucaelin authored and 43081j committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    3308f79 View commit details
    Browse the repository at this point in the history

  4. feat (dev-server-rollup): pass through resolve options

    @43081j
    43081j committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    e6ea158 View commit details
    Browse the repository at this point in the history

  5. feat: extract resolve options to plugin definition

    @43081j
    43081j committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    fd71f22 View commit details
    Browse the repository at this point in the history