Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update dependency @rollup/plugin-commonjs to v21 #1703

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 1, 2021

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@rollup/plugin-commonjs (source) ^18.0.0 -> ^21.1.0 age adoption passing confidence

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2021

πŸ¦‹ Changeset detected

Latest commit: a7f4772

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@web/dev-server-rollup Minor
@web/dev-server Minor
@web/test-runner Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@web-padawan web-padawan force-pushed the renovate/rollup-plugin-commonjs-21.x branch from ba4a12a to 19a9355 Compare October 7, 2021 09:28
@web-padawan web-padawan force-pushed the renovate/rollup-plugin-commonjs-21.x branch from 19a9355 to f4b235a Compare October 7, 2021 09:53
@web-padawan web-padawan changed the title chore(deps): update dependency @rollup/plugin-commonjs to v21 feat!: update dependency @rollup/plugin-commonjs to v21 Oct 7, 2021
@web-padawan
Copy link
Contributor

One test fails on Windows and I'm not sure what's the reason πŸ€”

  1) @rollup/plugin-commonjs
       can transform an es module compiled to commonjs module with a default exports:
     Error: Expected "import { __exports as foo } from "/__web-dev-server__/rollup/foo.js?web-dev-server-rollup-null-byte=%00" in string: 

import * as commonjsHelpers from "/__web-dev-server__/rollup/commonjsHelpers.js?web-dev-server-rollup-null-byte=%00commonjsHelpers.js";
import { __exports as foo } from "D:\a\web\web\packages\dev-server-rollup\test\node\fixtures\basic\foo.js?commonjs-exports"

@LarsDenBakker
Copy link
Member

A minor version bump is for breaking changes since we are still on v0. Its a dev dependency so no need to really do a version bump

@web-padawan
Copy link
Contributor

We also need to double check if #1700 is still an issue with @rollup/plugin-commonjs v21.

@web-padawan web-padawan marked this pull request as draft October 7, 2021 14:15
@renovate
Copy link
Contributor Author

renovate bot commented Oct 7, 2021

Autoclosing Skipped

This PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@web-padawan web-padawan force-pushed the renovate/rollup-plugin-commonjs-21.x branch from f4b235a to a7f4772 Compare November 2, 2021 11:00
@renovate
Copy link
Contributor Author

renovate bot commented Nov 28, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@Westbrook
Copy link
Member

Closing as out of date.

@Westbrook Westbrook closed this Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants