Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Rollup dependency to 2.56.2 #1623

Merged
merged 2 commits into from Aug 14, 2021
Merged

Conversation

web-padawan
Copy link
Contributor

@web-padawan web-padawan commented Aug 14, 2021

What I did

  1. Updated Rollup dependency to 2.56.2
  2. Fixed tests to align with the change landed in 2.55 - Use mutable bindings for default exports rollup/rollup#4182 (see this article for an overview of how the mutable live bindings work).

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2021

🦋 Changeset detected

Latest commit: 72a0f54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@web/dev-server-rollup Patch
@web/dev-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!!

@web-padawan web-padawan removed the request for review from LarsDenBakker August 14, 2021 16:25
@web-padawan web-padawan merged commit 49dcb6b into master Aug 14, 2021
@web-padawan web-padawan deleted the rollup-default-live branch August 14, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants