Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use __future__.annotations part 2: remove more of the typing.List, typing.Dict usages #83

Closed
wants to merge 2 commits into from
Closed

Use __future__.annotations part 2: remove more of the typing.List, typing.Dict usages #83

wants to merge 2 commits into from

Conversation

thundergolfer
Copy link
Contributor

Follow-up to #78.

@thundergolfer
Copy link
Contributor Author

Argh, I think I've hit pydantic/pydantic#2678

erikbern
erikbern approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@erikbern erikbern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@thundergolfer
Copy link
Contributor Author

@erikbern it's not working unfortunately. See #83 (comment)

@thundergolfer
Copy link
Contributor Author

Will close this until I work out a way to 100% replace from typing.List with list without breaking typer.

@ekzhang ekzhang deleted the jonathon/stdlib-container-type-annotations-pt2 branch September 27, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikbern erikbern erikbern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thundergolfer @erikbern