Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make background volume commits default experience #1830

Merged
merged 1 commit into from
May 24, 2024

Conversation

thundergolfer
Copy link
Contributor

Describe your changes

Previously if a user didn't specify the flag they wouldn't get background commits. When this merges they will.

#1823 merged only a few days ago. I'll merge this around mid-week next week.

cc @gimaker

Backward/forward compatibility checks

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Changelog

  • Background committing on modal.Volume mounts is now default behavior.

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

Copy link
Contributor

@gimaker gimaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thundergolfer thundergolfer merged commit 36c3d25 into main May 24, 2024
23 checks passed
@thundergolfer thundergolfer deleted the jonathon/make-bckgrd-cmmt-default branch May 24, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants