fix: regression in nfs get #1822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thundergolfer
force-pushed
the
jonathon/fix-nfs-get-regression
branch
from
3d0615d
to
13573dc
Compare
thundergolfer
force-pushed
the
jonathon/fix-nfs-get-regression
branch
from
13573dc
to
c28a1f2
Compare
ekzhang
requested changes
May 14, 2024
Comment on lines
+196
to
+218
| if "*" in remote_path: | ||
| await _volume_download(volume, remote_path, destination, force) | ||
| return | ||
|
|
||
| if destination != PIPE_PATH: | ||
| if destination.is_dir(): | ||
| destination = destination / remote_path.rsplit("/")[-1] | ||
|
|
||
| if destination.exists() and not force: | ||
| raise UsageError(f"'{destination}' already exists") | ||
|
|
||
| if not destination.parent.exists(): | ||
| raise UsageError(f"Local directory '{destination.parent}' does not exist") | ||
|
|
||
| @contextmanager | ||
| def _destination_stream(): | ||
| if destination == PIPE_PATH: | ||
| yield sys.stdout.buffer | ||
| else: | ||
| with NamedTemporaryFile(delete=False) as fp: | ||
| yield fp | ||
| shutil.move(fp.name, destination) | ||
|
|
There was a problem hiding this comment.
Can we fix _volume_download instead of introducing deviant behavior based on the path containing an asterisk?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
#1742 caused a regression in
nfs get. It can be repro'd with:User reported this here https://modal-com.slack.com/archives/C069RAH7X4M/p1715620466703749.
This wasn't caught by tests because our fake implementation was wrong. Fixed that.
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog