-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS_REGION in code sample for S3 bucket #1805
base: main
Are you sure you want to change the base?
Conversation
yirenlu92
commented
May 8, 2024
- Add AWS_REGION in code sample for S3 bucket
What effect does this have? |
Agree with @mwaskom's question. What's the region of (the bucket) and how do you find the region for the bucket. The other two key-values are more self-explanatory, but arguably could also get documented. |
Mountpoint supports Seems fair to add it as an optional env var. |
This was just a genuine question on my end; it’s not clear from the example what this is supposed to accomplish. (Are you setting the region you are connecting from? The region you want to mount in? Etc.) |
Thanks for adding the comments, makes a lot more sense. So that they remain readable, can we move the comments to a line above the parameter and wrap them at a reasonable character width? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bearing with me :)