Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS_REGION in code sample for S3 bucket #1805

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yirenlu92
Copy link
Contributor

  • Add AWS_REGION in code sample for S3 bucket

@mwaskom
Copy link
Contributor

mwaskom commented May 9, 2024

What effect does this have?

@thundergolfer
Copy link
Contributor

Agree with @mwaskom's question. What's the region of (the bucket) and how do you find the region for the bucket. The other two key-values are more self-explanatory, but arguably could also get documented.

@luiscape
Copy link
Member

Mountpoint supports AWS_REGION as a parameter. The main use-case seems to be resolving issues that may happen with "cross-region mount with a directory bucket", among other things.

Seems fair to add it as an optional env var.

@mwaskom
Copy link
Contributor

mwaskom commented May 13, 2024

This was just a genuine question on my end; it’s not clear from the example what this is supposed to accomplish. (Are you setting the region you are connecting from? The region you want to mount in? Etc.)

@mwaskom
Copy link
Contributor

mwaskom commented May 13, 2024

Thanks for adding the comments, makes a lot more sense.

So that they remain readable, can we move the comments to a line above the parameter and wrap them at a reasonable character width?

Copy link
Contributor

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants