Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Run all methods of a class in the same container pool #1789

Draft
wants to merge 67 commits into
base: main
Choose a base branch
from
Draft

Draft: Run all methods of a class in the same container pool #1789

wants to merge 67 commits into from

Conversation

freider
Copy link
Contributor

@freider freider commented May 3, 2024

Work in progress

TODO:

  1. Remove debugging code
  2. Clean up hacky quickfixes/make stuff a bit more readable
  3. Fix container entrypoint
  4. First release proto change
  5. Update some backend rpcs so they can return the new required fields
  6. Release a client without these new features that warns if keep_warm has different values for different methods or if .keep_warm() is being used on methods?

@freider freider changed the title Freider/class functions Draft: Run all methods of a class in the same container pool May 3, 2024
freider added 30 commits May 24, 2024 13:12
@freider
Cleanup
84d44a8
@freider
More clean
2936408
@freider
Merge branch 'freider/method-pooling-protos' into freider/class-funct…
de7e659 
…ions
@freider
Restore
8dfe534
@freider
Fix all tests
e020ef0
@freider
Fix types
acbca38
@freider
All tests passing
030e9dc
@freider
Merge remote-tracking branch 'origin/main' into freider/class-functions
7857e17
@freider
Merge remote-tracking branch 'origin/main' into freider/method-poolin…
4d59388 
…g-protos
@freider
Adds container entrypoint changes to support running multi-method ser…
fbb9aaf 
…vices
@freider
Minifix
e59bd85
@freider
Fix
455357b
@freider
Cleanup
f0d19ee
@freider
Refactor service to expose deps directly instead of the internal _Fun…
3442105 
…ction object
@freider
Adds basic test for multi-method execution in a single container
14dd620
@freider
Changes how PartialMethods implement the descriptor protocol
720790c 
* ModalWrappedCls().method is unchanged (returns the _Obj-bound Function object)
* ModalWrappedCls.method and UserCls.method now return the PartialFunction object - this is used by serialize(UserCls)
* UserCls().method now returns the original method bound to the UserCls instance - acts like vanilla python since that's what UserCls is
@freider
Merge branch 'freider/class-serialization-changes' into freider/class…
d5e5258 
…-functions
@freider
Merge branch 'freider/class-serialization-changes' into freider/metho…
ce95e49 
…d-pooling-entrypoint
@freider
Refactor to use serialized_cls instead of mangled serialized_fun
295aa24
@freider
Merge branch 'freider/method-pooling-entrypoint' into freider/class-f…
a2c71c3 
…unctions
@freider
Merge remote-tracking branch 'origin/main' into freider/class-functions
9ff49d6
@freider
Cleanup and fixes
0a7988a
@freider
oops
0cc707a
@freider
wip
6ba5919
@freider
Minor
640b731
@freider
Botched merge
f14f4eb
@freider
Fix tests
de882c0
@freider
Function id
590a794
@freider
Standardize invocation_function_id()
8f482df
@freider
Adds back closure introspection for methods
93af8b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@freider