-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No parent input if .spawn #1541
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.
@@ -235,13 +235,14 @@ def __init__(self, stub: api_grpc.ModalClientStub, function_call_id: str, client | |||
self.function_call_id = function_call_id # TODO: remove and use only input_id | |||
|
|||
@staticmethod | |||
async def create(function_id: str, args, kwargs, client: _Client) -> "_Invocation": | |||
async def create(function_id: str, nowait: bool, args, kwargs, client: _Client) -> "_Invocation": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: nowait
isn't immediately obvious what effects it has - maybe set_parent
or something? Is this related to whether we should kill child calls when the parent is terminated or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No description provided.