Adding throwsMany exception #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: antonio-manuel <contacto@antoniolopez.eu>
Co-authored-by: antonio-manuel <contacto@antoniolopez.eu>
sergiocostaN26
approved these changes
Oct 28, 2022
|
LGTM Can you please also add documentation for this in the README.md file? Thanks! |
Co-authored-by: daniel-dios <daniel.schezdios@gmail.com>
Hey, thanks for your comment, we just updated the documentation. We noticed we had to update the mockk-dsl.api, but we didn't found in the documentation any reference to this file, what is the purpose of it? Should it be included in the CONTRIBUTION file? Also, the pipeline is not running with my commits, do I need any granted permissions for that? |
Co-authored-by: daniel-dios <daniel.schezdios@gmail.com>
daniel-dios
force-pushed
the
add-throw-many-exceptions
branch
from
f1da3d7
to
87219d1
Compare
|
ping @Raibaz 馃懠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team! 馃槵馃
This is @antonio-manuel and @daniel-dios from @n26!
Since we are testing Kafka ErrorHandlers we wanted to stub a method to return 10 times a given exception and then success with this amazing library 馃檶
We are proposing this two new methods to make test even clearer!
Thanks a lot
馃挀