Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for issue #934 #937

Closed
wants to merge 1 commit into from
Closed

Conversation

diastremskii
Copy link
Contributor

This PR adds tests to demonstrate the issue #934
Since the problem reproduces with JVM 17+ bytecode, to reproduce the problem:

  1. Remove DisabledForJreRange annotation from the tests
  2. Set JVM target here to JavaVersion.VERSION_17
  3. Run the tests with -PjavaToolchainTestVersion=17

@cliffred
Copy link
Contributor

cliffred commented Oct 4, 2022

I've opened a PR with a fix for issue #934, I've merged your commit into that branch to have test coverage, see #939.

@diastremskii
Copy link
Contributor Author

I've opened a PR with a fix for issue #934, I've merged your commit into that branch to have test coverage, see #939.

Thanks! Closing this PR. Perhaps it would make sense to remove DisabledForJreRange from the tests in your PR? Since there is a fix, tests should run on JVM 17+

@cliffred
Copy link
Contributor

cliffred commented Oct 5, 2022

Removed the annotations, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants