Fix parallel testing flag #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evenprime
force-pushed
the
fix_parallel_testing
branch
from
3ae2029
to
b2a2726
Compare
Evenprime
force-pushed
the
fix_parallel_testing
branch
from
b2a2726
to
131bc61
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1133
There was an attempt to fix the issue, but the implementation of the flag
requireParallelTestingis broken. The intention was to enable calling ofunmockkAll()without callingclearAllMocks(), but the way it got implemented makes that impossible. Currently, ifkeepMocksflag is false, both methods get called and therequireParallelTestinggets ignored.This fixes the logic, such that setting the flag
requireParallelTestingto true properly prevents theclearAllMocks()call, independent of the state of thekeepMocksflag.