Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 293: support capture nullable with slot #1109

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

stengvac
Copy link

@stengvac stengvac commented Jul 4, 2023

Hello,

This is PR for Allow to Capture nullable values with CapturingSlot see 293. Seems it works according to tests.

Changes on CapturingSlot API are big, I can make them less invasive, but currently I don`t know how much problem it is. I mean removal of

public field captured Ljava/lang/Object; //is not field only get/set now
public final fun setCaptured (Z)V // only getter now
public final fun setNull (Z)V // only getter now

@Raibaz
Copy link
Collaborator

Raibaz commented Jul 18, 2023

Thanks a lot for this!

Can you also please add mention of this in the docs in README.md?

@stengvac
Copy link
Author

Hello, README.md updated and added one more test for CapturingSlot.

@Raibaz Raibaz merged commit 3388b3b into mockk:master Jul 26, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants