Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Kotlin and Java Toolchain properties, and setting them in CI #1056

Merged
merged 5 commits into from Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/gradle.yml
Expand Up @@ -37,8 +37,8 @@ jobs:
run: >
./gradlew check
--stacktrace
-Pkotlin.version=${{ matrix.kotlin-version }}
-PjavaToolchainTestVersion=${{ matrix.java-version }}
-Pio_mockk_kotlin_version=${{ matrix.kotlin-version }}
-Pio_mockk_java_toolchain_test_version=${{ matrix.java-version }}

android-instrumented-tests:
runs-on: macos-latest
Expand Down
18 changes: 0 additions & 18 deletions buildSrc/build.gradle.kts
@@ -1,5 +1,3 @@
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
`kotlin-dsl`
}
Expand All @@ -25,19 +23,3 @@ dependencies {

implementation("org.jetbrains.kotlinx:binary-compatibility-validator:$binaryCompatibilityValidator")
}

tasks.withType<KotlinCompile>().configureEach {
kotlinOptions {
jvmTarget = "11"
}
}

kotlin {
jvmToolchain {
languageVersion.set(JavaLanguageVersion.of(11))
}
}

kotlinDslPluginOptions {
jvmTarget.set("11")
}
4 changes: 3 additions & 1 deletion buildSrc/src/main/kotlin/buildsrc/config/Deps.kt
Expand Up @@ -3,7 +3,9 @@ package buildsrc.config
import org.gradle.api.JavaVersion
import org.gradle.api.Project

fun Project.kotlinVersion() = findProperty("kotlin.version")?.toString() ?: Deps.Versions.kotlinDefault
fun Project.kotlinVersion(): String =
providers.gradleProperty("io_mockk_kotlin_version")
.getOrElse(Deps.Versions.kotlinDefault)

object Deps {
object Versions {
Expand Down
Expand Up @@ -25,8 +25,8 @@ tasks.withType<KotlinCompile>().configureEach {
val javaToolchains: JavaToolchainService = extensions.getByType()


val javaToolchainMainVersion = javaLanguageVersion("javaToolchainMainVersion")
val javaToolchainTestVersion = javaLanguageVersion("javaToolchainTestVersion")
val javaToolchainMainVersion = javaLanguageVersion("io_mockk_java_toolchain_main_version")
val javaToolchainTestVersion = javaLanguageVersion("io_mockk_java_toolchain_test_version")


// The Java Toolchains that will compile/launch *main* code
Expand Down
10 changes: 7 additions & 3 deletions gradle.properties
Expand Up @@ -8,8 +8,12 @@ org.gradle.welcome=never
org.gradle.jvmargs=-XX:MaxMetaspaceSize=768m
kotlin.mpp.stability.nowarn=true
localrepo=build/maven-local-repo
android.useAndroidX=true
########################
# version of Java that will be used to build the project
javaToolchainMainVersion=11
io_mockk_java_toolchain_main_version=11
# the Java version tests will run against - this is overridden in the GitHub actions
javaToolchainTestVersion=11
io_mockk_java_toolchain_test_version=11
########################
# Android properties:
android.useAndroidX=true
########################