Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up JDK-8 related code #2883

Merged
merged 7 commits into from
Jan 24, 2023
Merged

Clean up JDK-8 related code #2883

merged 7 commits into from
Jan 24, 2023

Conversation

reta
Copy link
Contributor

@reta reta commented Jan 22, 2023

Signed-off-by: Andriy Redko drreta@gmail.com

Clean up JDK-8 related code.
Fixes #2879

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

Signed-off-by: Andriy Redko <drreta@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2023

Codecov Report

Base: 83.69% // Head: 85.81% // Increases project coverage by +2.11% 🎉

Coverage data is based on head (b196998) compared to base (91223f8).
Patch coverage: 90.47% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2883      +/-   ##
============================================
+ Coverage     83.69%   85.81%   +2.11%     
+ Complexity     2861     2844      -17     
============================================
  Files           327      324       -3     
  Lines          8785     8601     -184     
  Branches       1068     1059       -9     
============================================
+ Hits           7353     7381      +28     
+ Misses         1155      947     -208     
+ Partials        277      273       -4     
Impacted Files Coverage Δ
...on/bytebuddy/InlineDelegateByteBuddyMockMaker.java 77.56% <ø> (+0.63%) ⬆️
...creation/bytebuddy/SubclassByteBuddyMockMaker.java 52.11% <ø> (+2.11%) ⬆️
.../main/java/org/mockito/internal/util/Platform.java 72.72% <ø> (-4.20%) ⬇️
...al/stubbing/defaultanswers/ReturnsEmptyValues.java 96.96% <90.00%> (ø)
...rg/mockito/internal/debugging/LocationFactory.java 100.00% <100.00%> (+33.33%) ⬆️
.../internal/creation/bytebuddy/MockMethodAdvice.java 81.94% <0.00%> (+0.28%) ⬆️
...l/stubbing/answers/AnswerFunctionalInterfaces.java 94.79% <0.00%> (+1.04%) ⬆️
.../creation/bytebuddy/SubclassBytecodeGenerator.java 69.18% <0.00%> (+2.90%) ⬆️
...rnal/creation/bytebuddy/MockMethodInterceptor.java 77.77% <0.00%> (+7.40%) ⬆️
...ckito/internal/creation/bytebuddy/TypeSupport.java 78.57% <0.00%> (+21.42%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Andriy Redko <drreta@gmail.com>
…uration classes

Signed-off-by: Andriy Redko <drreta@gmail.com>
build.gradle Show resolved Hide resolved
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta reta marked this pull request as ready for review January 24, 2023 02:33
@reta
Copy link
Contributor Author

reta commented Jan 24, 2023

@TimvdLippe please let me know if I missed some places, I think we are good to go, thank you!

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you!

@TimvdLippe TimvdLippe merged commit 4775c67 into mockito:main Jan 24, 2023
@TWiStErRob
Copy link
Contributor

Note: this was partially reverted in #2891 to supply Android compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up JDK-8 related code
4 participants