Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade errorprone from 2.14.0 to 2.16 #2794

Merged
merged 1 commit into from Nov 22, 2022

Conversation

XN137
Copy link
Contributor

@XN137 XN137 commented Nov 21, 2022

we need to fix the following violation:

StubbingWithCustomAnswerTest.java:113: error: [DoNotCall] Calling getClass on Method returns the Class object for Method, you probably meant to retrieve the class containing the method represented by this Method using getDeclaringClass

Supersedes and closes #2771

we need to fix the following violation:

StubbingWithCustomAnswerTest.java:113: error: [DoNotCall] Calling getClass on Method returns the Class object for Method,
you probably meant to retrieve the class containing the method represented by this Method using getDeclaringClass
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Base: 86.20% // Head: 86.04% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (dce56bd) compared to base (3faa002).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2794      +/-   ##
============================================
- Coverage     86.20%   86.04%   -0.17%     
+ Complexity     2833     2831       -2     
============================================
  Files           320      320              
  Lines          8596     8596              
  Branches       1060     1060              
============================================
- Hits           7410     7396      -14     
- Misses          905      918      +13     
- Partials        281      282       +1     
Impacted Files Coverage Δ
...nternal/debugging/VerboseMockInvocationLogger.java 92.68% <0.00%> (-4.88%) ⬇️
...al/creation/bytebuddy/InlineBytecodeGenerator.java 84.74% <0.00%> (-2.97%) ⬇️
...ito/internal/stubbing/InvocationContainerImpl.java 92.75% <0.00%> (-1.45%) ⬇️
...on/bytebuddy/InlineDelegateByteBuddyMockMaker.java 70.05% <0.00%> (-0.83%) ⬇️
...java/org/mockito/internal/exceptions/Reporter.java 90.79% <0.00%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TimvdLippe TimvdLippe merged commit 544d0b6 into mockito:main Nov 22, 2022
@TimvdLippe
Copy link
Contributor

Awesome, thanks!

@XN137 XN137 deleted the upgrade-errorprone branch November 22, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants