Include Java 19 in CI #2791
Closed
Include Java 19 in CI #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this PR? We are now using Gradle 7.6 which supports Java 19 |
|
Note that a lot of the Loom code in the VM is disabled in 19 unless you run with |
Since Project Loom is a fairly significant internal architecture change within Java, it is probably worth running CI against it as a baseline.
|
@TimvdLippe sorry about that, totally missed this message. Rebased as requested! |
|
Looks like these might be test failures to do with the encapsulation of JDK internals that is in place now, possibly? |
|
Looks related to: https://bugs.openjdk.org/browse/JDK-8266010 Probably the test can just be updated to include the new method (There are already 2 possible cases, for pre-Java 9 and post). |
|
Yeah let's update the test. It's only an additional 0. |
|
Superseded by #3145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Project Loom is a fairly significant internal architecture change within Java, it is probably worth running CI against it as a baseline.
This is also a useful exercise in detecting potential test failures that may eventually impact the next LTS release for Java (Java 21 in September 2023).
Relates to #2767, and #2780.