Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored spy equals/hashcode fix #2583

Closed

Conversation

cdalexndr
Copy link

Fixes #2331

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't revert this patch, as it will break caching of classes. I thought we added a regression test for that, but I would have to double check.

In any case, we will have to fix this in a different way, although unfortunately it is unclear what that entails.

@cdalexndr
Copy link
Author

We can't revert this patch, as it will break caching of classes

Can you provide more details about this issue?

The cache key was fixed by 4f81d4f and this revert includes that fix.

@TimvdLippe
Copy link
Contributor

#2400 was reverted per #2400 (comment) in #2402 The fix was not working as intended and broke the class cache.

@cdalexndr cdalexndr closed this Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spy doesn't forward hashcode/equals to actual object
2 participants