Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #348 In stub mode even the last invocation is irrelevant #2571

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Feb 18, 2022

Hi there,

After re-reading #348, I think the invocation reservoir, doesn't have to keep the last invocation.

This PR changes the semantics of the invocation reservoir, so no invocations are stored.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@bric3 bric3 marked this pull request as draft February 18, 2022 14:57
@bric3 bric3 force-pushed the stub-do-not-store-last-invocation branch from 3ae0ad1 to e50823b Compare February 18, 2022 16:50
@davidburstromspotify
Copy link

Hi! Will this PR be worked on?

@eduardbosch-jt
Copy link

Hi!
What is the status of this PR?
I think that it makes sense to not store any invocation when using configuring a mock with stubOnly.

I'm actually having come leaks due to this.

I'm trying to remove them with clearInvocations, but anyway, it looks like stubOnly should not store any invocation reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants