Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions.errorprone from 2.10.0 to 2.11.0 #2553

Closed
wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 26, 2022

Bumps versions.errorprone from 2.10.0 to 2.11.0.
Updates error_prone_core from 2.10.0 to 2.11.0

Release notes

Sourced from error_prone_core's releases.

Error Prone 2.11.0

Error Prone now requires JDK 11 or newer (google/error-prone#2730).

New checks

Fixed issues: #2641, #2705, #2776, #2798, #2799, #2819, #2820, #2831, #2833, #2834, #2835, #2861, #2873, #2889, #2892, #2901

Full Changelog: google/error-prone@v2.10.0...v2.11.0

Commits
  • 6439153 Release Error Prone 2.11.0
  • d33ab70 Add backreferences to b/216306810
  • 3f61879 Decrease TooManyParameters default limit from 10 to 9.
  • c2e14f2 Make ASTHelpers.getSymbol(MethodInvocationTree) and friends throw instead o...
  • c18ae52 Autofix all the AnnotationPosition findings in EP.
  • 4698c8e intellij project files update
  • f6a508f Bump more deps.
  • 048a664 Document missing itself lock expression.
  • fbaa55b Update OrphanedFormatString to warn on log("hello %s")
  • e09ca6f More version updates
  • Additional commits viewable in compare view

Updates error_prone_test_helpers from 2.10.0 to 2.11.0

Release notes

Sourced from error_prone_test_helpers's releases.

Error Prone 2.11.0

Error Prone now requires JDK 11 or newer (google/error-prone#2730).

New checks

Fixed issues: #2641, #2705, #2776, #2798, #2799, #2819, #2820, #2831, #2833, #2834, #2835, #2861, #2873, #2889, #2892, #2901

Full Changelog: google/error-prone@v2.10.0...v2.11.0

Commits
  • 6439153 Release Error Prone 2.11.0
  • d33ab70 Add backreferences to b/216306810
  • 3f61879 Decrease TooManyParameters default limit from 10 to 9.
  • c2e14f2 Make ASTHelpers.getSymbol(MethodInvocationTree) and friends throw instead o...
  • c18ae52 Autofix all the AnnotationPosition findings in EP.
  • 4698c8e intellij project files update
  • f6a508f Bump more deps.
  • 048a664 Document missing itself lock expression.
  • fbaa55b Update OrphanedFormatString to warn on log("hello %s")
  • e09ca6f More version updates
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `versions.errorprone` from 2.10.0 to 2.11.0.

Updates `error_prone_core` from 2.10.0 to 2.11.0
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.10.0...v2.11.0)

Updates `error_prone_test_helpers` from 2.10.0 to 2.11.0
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.10.0...v2.11.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.errorprone:error_prone_test_helpers
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 26, 2022
@Stephan202
Copy link
Contributor

The Java 8 build fails because of

java.lang.UnsupportedClassVersionError: com/google/errorprone/ErrorProneJavacPlugin has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

Due to this failure the JDK 11/17 builds were cancelled, but there's actually a secondary incompatibility here. On JDK 11+ the build fails with:

/tmp/mockito/subprojects/errorprone/src/main/java/org/mockito/errorprone/bugpatterns/MockitoAnyIncorrectPrimitiveType.java:52: error: no suitable method found for withParameters(no arguments)
      staticMethod().onClassAny(CLASS_NAMES).withNameMatching(METHOD_NAME_PATTERN).withParameters();
                                                                                  ^
    method MethodNameMatcher.withParameters(String,String...) is not applicable
      (actual and formal argument lists differ in length)
    method MethodNameMatcher.withParameters(Iterable<String>) is not applicable
      (actual and formal argument lists differ in length)
1 error

This source and bytecode incompatibility makes mockito-errorprone incompatible with Error Prone 2.11.0. (Just wanted to share that holding off on this upgrade has other implications, unfortunately.)

@TimvdLippe
Copy link
Contributor

Ah thanks for letting us know. I was planning on taking a look tomorrow and will probably publish 4.3.2 to fix the issue.

This also fixes #2554, by using `.withNoParameters()` instead.
@TimvdLippe
Copy link
Contributor

@dependabot squash and merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 27, 2022

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@TimvdLippe
Copy link
Contributor

@dependabot cancel merge

For some reason, Java 8 chooses the wrong subclass for this specific use
case. All other assertions are fine and this doesn't happen on JDK 11.
Therefore, let's extract it into a method to force the correct type.
@TimvdLippe
Copy link
Contributor

Fixed in #2608

@TimvdLippe TimvdLippe closed this Apr 6, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 6, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/versions.errorprone-2.11.0 branch April 6, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants