Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all Incubating annotations #2437

Merged
merged 1 commit into from Oct 4, 2021
Merged

Conversation

TimvdLippe
Copy link
Contributor

For all of these APIs, we have been shipping them for at least 1 major
release. We consider all of these APIs part of the public API contract
now and therefore we should mark them as such.

This PR removes all usages of the annotation. If we were to later remove
an API, it will first have to be deprecated and then removed in a
subsequent major release. However, we have no plans to do so with any of
these APIs.

Closes #2433

For all of these APIs, we have been shipping them for at least 1 major
release. We consider all of these APIs part of the public API contract
now and therefore we should mark them as such.

This PR removes all usages of the annotation. If we were to later remove
an API, it will first have to be deprecated and then removed in a
subsequent major release. However, we have no plans to do so with any of
these APIs.
@TimvdLippe TimvdLippe requested a review from raphw October 1, 2021 15:17
Copy link
Member

@raphw raphw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is right to do, those APIs have partially been stable for years and I do not assume them to change with any higher probability than any of the others.

@TimvdLippe TimvdLippe merged commit 7032574 into main Oct 4, 2021
@TimvdLippe TimvdLippe deleted the remove-incubating-apis branch October 4, 2021 21:51
@mockitoguy
Copy link
Member

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roadmap for Mockito.MockedStatic<T>
3 participants