New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI on Java 17 #2417
Merged
Merged
Run CI on Java 17 #2417
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
06138a0
Run CI on Java 17
TimvdLippe f7435b2
Use different 17-ea version
TimvdLippe 90f0063
Do not run Android tests on JDK 17
TimvdLippe ab5fea9
Update Jacoco
TimvdLippe 1979a4e
Fix tests
TimvdLippe 69d2e8f
Remove unsupported VM option
TimvdLippe a3a6e33
Fix tests and CI.
raphw f2e4b0a
Fix formatting.
raphw File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
import net.bytebuddy.ClassFileVersion; | ||
import net.bytebuddy.description.modifier.TypeManifestation; | ||
import net.bytebuddy.dynamic.DynamicType; | ||
import org.junit.Ignore; | ||
import org.junit.Test; | ||
import org.mockito.internal.creation.MockSettingsImpl; | ||
import org.mockito.plugins.MockMaker; | ||
|
@@ -34,6 +35,7 @@ public void is_type_mockable_excludes_primitive_wrapper_classes() { | |
} | ||
|
||
@Test | ||
@Ignore("Broken on JDK 17") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We were only running this on 17, but it seems to be failing anyways 😢 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed the test! |
||
public void is_type_mockable_excludes_sealed_classes() { | ||
// is only supported on Java 17 and later | ||
if (ClassFileVersion.ofThisVm().isAtMost(ClassFileVersion.JAVA_V16)) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,5 +15,4 @@ tasks.javadoc.enabled = false | |
|
||
test { | ||
maxHeapSize = "128m" | ||
jvmArgs = ["-XX:MaxPermSize=128m"] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be without ea now.