Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2311 : print the fully qualified class names. #2325

Closed
wants to merge 3 commits into from
Closed

Fixes #2311 : print the fully qualified class names. #2325

wants to merge 3 commits into from

Conversation

chaehwanli
Copy link

@chaehwanli chaehwanli commented Jun 11, 2021

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

-. replace getName() with getSimpleName()

@chaehwanli chaehwanli changed the title Fixes mockito#2311 : print the fully qualified class names. Fixes #2311 : print the fully qualified class names. Jun 11, 2021
@TimvdLippe
Copy link
Contributor

We no longer use the release/3.x branch, so #2320 suffices for now. I think I will have a chance tomorrow to review the PR.

@TimvdLippe TimvdLippe closed this Jun 11, 2021
@chaehwanli
Copy link
Author

I'm just showing that I'm a complete beginner.
Using the release branch for PR... I'm sorry for wasting your time.

@TimvdLippe
Copy link
Contributor

Don't worry about it, our branch naming was confusing! It's an easy mistake to make, so no worries at all 😄

@chaehwanli
Copy link
Author

thank you~ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants