Apply automated ErrorProne fixes #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the result of running ErrorProne on the codebase. Most notably, it adds missing override annotations, adds private constructors for classes that should not be subclassed, removes redundant generic type specified and fixes handling of casts/instance checks.
|
@raphw Not sure if it is worth to review, as it is a mechanical change that passes all tests. So feel free to rubberstamp. |
|
I am assuming no objections on this mechanical PR and will therefore merge it. Let me know if you do have any objections and am happy to resolve them. |
This was referenced May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of running ErrorProne on the codebase. Most notably,
it adds missing override annotations, adds private constructors for
classes that should not be subclassed, removes redundant generic type
specified and fixes handling of casts/instance checks.