Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jdk 16 and 17 to ci #2211

Closed
wants to merge 1 commit into from

Conversation

XenoAmess
Copy link

@XenoAmess XenoAmess commented Feb 21, 2021

Hey,

Thanks for the contribution, this is awesome.
As you may have read, project members have somehow an opinionated view on what and how should be
Mockito, e.g. we don't want mockito to be a feature bloat.
There may be a thorough review, with feedback -> code change loop.

Which branch :

  • On mockito 3.x, make your pull request target release/3.x
  • On mockito 2.x, make your pull request target release/2.x (2.x is in maintenance mode)

This block can be removed
_Something wrong in the template fix it here .github/PULL_REQUEST_TEMPLATE.md

check list

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@TimvdLippe
Copy link
Contributor

Gradle does not support JDK 16+ yet, so we are blocked on gradle/gradle#13481 for now.

@XenoAmess
Copy link
Author

XenoAmess commented Feb 21, 2021

Gradle does not support JDK 16+ yet, so we are blocked on gradle/gradle#13481 for now.

@TimvdLippe
Yes indeed. This pr is just for showing this using ci (for tracking a jdk 16 bug in another repo who use mockito). we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants