Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"But invoked here" lists the invocation parameters #2188

Conversation

eugenelesnov
Copy link
Contributor

Fixes #2058

@codecov-io
Copy link

codecov-io commented Jan 23, 2021

Codecov Report

Merging #2188 (cd39a7e) into release/3.x (0630886) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #2188      +/-   ##
=================================================
- Coverage          84.90%   84.85%   -0.05%     
- Complexity          2722     2724       +2     
=================================================
  Files                325      325              
  Lines               8280     8294      +14     
  Branches             989      989              
=================================================
+ Hits                7030     7038       +8     
- Misses               981      984       +3     
- Partials             269      272       +3     
Impacted Files Coverage Δ Complexity Δ
...java/org/mockito/internal/exceptions/Reporter.java 91.83% <73.33%> (-0.98%) 96.00 <4.00> (+3.00) ⬇️
...ification/checkers/NumberOfInvocationsChecker.java 100.00% <100.00%> (ø) 11.00 <0.00> (ø)
...l/creation/bytebuddy/InlineByteBuddyMockMaker.java 69.74% <0.00%> (-0.58%) 50.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0630886...cd39a7e. Read the comment docs.

@eugenelesnov
Copy link
Contributor Author

It might be a good idea to add similar code for Reporter#tooManyActualInvocations

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR roughly looks okay. I will do some polish tomorrow to clean some things and improve test coverage and then I will merge it. Thanks!

@TimvdLippe
Copy link
Contributor

@eugenelesnov I don't have permission to push to your PR. Could you please pull in https://github.com/mockito/mockito/tree/but-invoked-here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"But invoked here" should list the invocation parameters
3 participants