New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2030 : DOCS Added reference to requirements to Java 8 support in Android #2031
Fixes #2030 : DOCS Added reference to requirements to Java 8 support in Android #2031
Conversation
Codecov Report
@@ Coverage Diff @@
## release/3.x #2031 +/- ##
=================================================
+ Coverage 84.88% 84.91% +0.02%
Complexity 2703 2703
=================================================
Files 325 325
Lines 8198 8198
Branches 979 979
=================================================
+ Hits 6959 6961 +2
Misses 968 968
+ Partials 271 269 -2
Continue to review full report at Codecov.
|
We kind of resolved this but got stuck on the Objenesis version. I think the best way to address this is the fixation of the Objenesis version for the mockito-android bundle as suggested elsewhere. |
Great @raphw. Do you refer to set objenesis version to 2.6 in the android module? |
Yes, I think that's the way to go. Setting these requirements gives the wrong impression since it can be so easily avoided. |
Ok, well, I think that with something like this it could be fixed:
Also the output of ./gradlew -q dependencies for the android module show this:
If you are ok with this, I can send it on a new PR. |
@TimvdLippe Thanks for pointing me that! also that PR looks more complete. So, I think this PR is not needed. If you like I can add a small reference to Java 8 requirements for Android in the previous paragraph, something like: ... on Android due to limitations in the Android VM (See Java 8 support). If you think is not necessary I can close the PR instead. |
Hi guys, I see the PR #2024 was already merged. What do you think about this one? |
It is a well-known limitation of the Android VMs, so I don't think it is necessary. The build system should prevent users from building the project and they will see an explanatory message. I would therefore like to wait with adding additional documentation. If there is further confusion, we could add a clarifying message to our main documentation indeed. |
Nice @TimvdLippe , so I close this one. Please let me know if there something I can help. |
Hi Guys
This is my first contribution here, let me know if this can be improved in some way.
check list
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant