New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Travis] Replace JDK 9/10 with 14 #1945
Conversation
9/10 are EOL since September 2018. 14 is the currently supported Java version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build is failing however I'm +1 to the goals of this PR. Thx!
Yeah I am working on resolving the build issue. We need to upgrade our Gradle version. Sadly that turns out to be a whole rabbithole, but I think I am close. |
This included a couple of breaking changes: - The build plugin is now part of the Gradle Enterprise plugin - The osgi plugin was removed, for which we have to use the bndtools plugin instead - Kotlin version has to be updated, including their coroutine library versions Gradle 6 is required for us to build on Java 14. Supersedes and closes #1923
@TimvdLippe it looks like we also have to use errorprone 2.4.0 since this is the first version which actually supports java 14.
|
@epeee Yes indeed. Were you able to get Gradle working on your machine?! |
yes. Furthermore, also the latest travis build (https://travis-ci.org/github/mockito/mockito/jobs/698954197) is failing with the message posted previously. |
Interesting, because I was looking at https://travis-ci.org/github/mockito/mockito/jobs/698954215 which is failing for a completely different reason :O |
I wonder maybe if the build cache is not working on one job, but is working on the other. Not sure how to diagnose this issue though. |
Oh, on the push Travis build, both tasks failed on the ErrorProne issue, but not the Gradle compilation issue. So out of 3 tasks, only the 1 on the PR build is failing. |
Codecov Report
@@ Coverage Diff @@
## release/3.x #1945 +/- ##
=================================================
- Coverage 86.76% 86.21% -0.56%
- Complexity 2494 2542 +48
=================================================
Files 311 318 +7
Lines 6552 6738 +186
Branches 821 838 +17
=================================================
+ Hits 5685 5809 +124
- Misses 670 715 +45
- Partials 197 214 +17
Continue to review full report at Codecov.
|
I purged the corrupt Travis cache and was able to get a passing build. See gradle/gradle#13444 (comment) for more info. |
9/10 are EOL since September 2018. 14 is the currently supported Java version.
9/10 are EOL since September 2018. 14 is the currently supported
Java version.