New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update report message to use any() instead of anyObject() #1931
Conversation
because anyObject() has already been deprecated, it would be better to push to use any()
Codecov Report
@@ Coverage Diff @@
## release/3.x #1931 +/- ##
==============================================
Coverage 86.67% 86.67%
Complexity 2526 2526
==============================================
Files 318 318
Lines 6650 6650
Branches 832 832
==============================================
Hits 5764 5764
Misses 685 685
Partials 201 201
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks!
Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
This updates JUnit, TestContainers, Lombok, and Mockito together as it wasn't possible to only update TestContainers alone since it also depends on JUnit, see PR JanusGraph#2972. The same applies to Mockito. These changes were necessary to update Mockito to v4: Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
This updates JUnit, TestContainers, Lombok, and Mockito together as it wasn't possible to only update TestContainers alone since it also depends on JUnit, see PR JanusGraph#2972. The same applies to Mockito. These changes were necessary to update Mockito to v4: Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Calling `property()` on a mocked `StandardVertex` resulted in a `NullPointer` exception, but we can also simply use a `DetachedProperty` as all accesses to that property on the vertex are also already mocked. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
This updates JUnit, TestContainers, Lombok, and Mockito together as it wasn't possible to only update TestContainers alone since it also depends on JUnit, see PR #2972. The same applies to Mockito. These changes were necessary to update Mockito to v4: Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Calling `property()` on a mocked `StandardVertex` resulted in a `NullPointer` exception, but we can also simply use a `DetachedProperty` as all accesses to that property on the vertex are also already mocked. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
Because
anyObject()
has already been deprecated, it would be better to push to useany()
instead.check list
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant