Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixed undetected unused stubbing when matching previous stubbed call" #1878

Conversation

TimvdLippe
Copy link
Contributor

Reverts #1847

Fixes #1877
Based on feedback in #1846

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #1878 into release/3.x will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##             release/3.x    #1878     +/-   ##
================================================
+ Coverage          86.73%   86.84%   +0.1%     
+ Complexity          2521     2518      -3     
================================================
  Files                316      316             
  Lines               6635     6622     -13     
  Branches             831      829      -2     
================================================
- Hits                5755     5751      -4     
+ Misses               679      672      -7     
+ Partials             201      199      -2
Impacted Files Coverage Δ Complexity Δ
...ito/internal/stubbing/InvocationContainerImpl.java 95% <ø> (-0.78%) 31 <0> (-3)
...to/internal/stubbing/StubbedInvocationMatcher.java 100% <ø> (ø) 9 <0> (ø) ⬇️
...ava/org/mockito/internal/reporting/Pluralizer.java 80% <ø> (-3.34%) 4 <0> (-2)
...java/org/mockito/internal/exceptions/Reporter.java 93.51% <100%> (-0.03%) 93 <0> (ø)
...ito/internal/creation/bytebuddy/ModuleHandler.java 26.92% <0%> (+0.96%) 2% <0%> (ø) ⬇️
...al/creation/bytebuddy/SubclassInjectionLoader.java 73.68% <0%> (+21.05%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc25440...9ab789b. Read the comment docs.

@TimvdLippe TimvdLippe merged commit d953509 into release/3.x Feb 26, 2020
epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
@TimvdLippe TimvdLippe deleted the revert-1847-fix-unused-stubbing-with-implicit-eq-matchers branch October 31, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Overriding stubbing
2 participants