-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add ErrorProne MockitoInternalUsage checker #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This checker will warn on any usage of a Mockito internal symbol. Since we do not guarantee API stability on symbols in our internal packages, users should not rely on them. This checker can be used to enforce that they are unused.
8b95bd7
to
3096572
Compare
…ne plugins This checker is opensourced at mockito/mockito#1690 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244160840
…ne plugins This checker is opensourced at mockito/mockito#1690 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244160840
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - good idea to have such an offering, makes this rule also more explicit.
I will merge this after #1693 |
Codecov Report
@@ Coverage Diff @@
## release/2.x #1690 +/- ##
=================================================
- Coverage 12.26% 12.24% -0.02%
Complexity 318 318
=================================================
Files 307 308 +1
Lines 6475 6483 +8
Branches 811 812 +1
=================================================
Hits 794 794
- Misses 5553 5561 +8
Partials 128 128
Continue to review full report at Codecov.
|
…ne plugins This checker is opensourced at mockito/mockito#1690 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244160840 (cherry picked from commit 8e821c8)
This checker will warn on any usage of a Mockito internal symbol. Since
we do not guarantee API stability on symbols in our internal packages,
users should not rely on them. This checker can be used to enforce that
they are unused.