Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrorProne MockitoInternalUsage checker #1690

Merged
merged 3 commits into from Apr 30, 2019

Conversation

TimvdLippe
Copy link
Contributor

This checker will warn on any usage of a Mockito internal symbol. Since
we do not guarantee API stability on symbols in our internal packages,
users should not rely on them. This checker can be used to enforce that
they are unused.

This checker will warn on any usage of a Mockito internal symbol. Since
we do not guarantee API stability on symbols in our internal packages,
users should not rely on them. This checker can be used to enforce that
they are unused.
@TimvdLippe TimvdLippe force-pushed the opensource-mockito-internal-usage branch from 8b95bd7 to 3096572 Compare April 17, 2019 16:15
ronshapiro pushed a commit to google/error-prone that referenced this pull request Apr 18, 2019
…ne plugins

This checker is opensourced at mockito/mockito#1690

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=244160840
cushon pushed a commit to google/error-prone that referenced this pull request Apr 18, 2019
…ne plugins

This checker is opensourced at mockito/mockito#1690

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=244160840
@TimvdLippe TimvdLippe requested a review from raphw April 22, 2019 21:08
Copy link
Member

@raphw raphw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good idea to have such an offering, makes this rule also more explicit.

@TimvdLippe
Copy link
Contributor Author

I will merge this after #1693

@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #1690 into release/2.x will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/2.x    #1690      +/-   ##
=================================================
- Coverage          12.26%   12.24%   -0.02%     
  Complexity           318      318              
=================================================
  Files                307      308       +1     
  Lines               6475     6483       +8     
  Branches             811      812       +1     
=================================================
  Hits                 794      794              
- Misses              5553     5561       +8     
  Partials             128      128
Impacted Files Coverage Δ Complexity Δ
...o/errorprone/bugpatterns/MockitoInternalUsage.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b64929...82d2ade. Read the comment docs.

@TimvdLippe TimvdLippe merged commit 87a012b into release/2.x Apr 30, 2019
@TimvdLippe TimvdLippe deleted the opensource-mockito-internal-usage branch April 30, 2019 15:58
Stephan202 pushed a commit to PicnicSupermarket/error-prone that referenced this pull request Nov 17, 2019
…ne plugins

This checker is opensourced at mockito/mockito#1690

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=244160840

(cherry picked from commit 8e821c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants