Skip to content

Commit

Permalink
Use new CodeCov uploader (#2447)
Browse files Browse the repository at this point in the history
Per https://about.codecov.io/blog/introducing-codecovs-new-uploader/ the Bash uploader has been deprecated.
The Bash uploader will randomly stop working, meaning we won't be able to inspect our code coverage reports.

Instead, we should be using the new uploader.
We should also check its integrity to avoid a repeat of the security vulnerability in the Bash uploader.
  • Loading branch information
TimvdLippe committed Oct 17, 2021
1 parent 2697478 commit 29eb4ee
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion .github/workflows/ci.yml
Expand Up @@ -64,7 +64,18 @@ jobs:
- name: 7. Upload coverage report
run: |
./gradlew coverageReport -s --scan && cp build/reports/jacoco/mockitoCoverage/mockitoCoverage.xml jacoco.xml
bash <(curl -s https://codecov.io/bash)
curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring --keyring trustedkeys.gpg --import # One-time step
curl -Os https://uploader.codecov.io/latest/linux/codecov
curl -Os https://uploader.codecov.io/latest/linux/codecov.SHA256SUM
curl -Os https://uploader.codecov.io/latest/linux/codecov.SHA256SUM.sig
gpgv codecov.SHA256SUM.sig codecov.SHA256SUM
shasum -a 256 -c codecov.SHA256SUM
chmod +x codecov
./codecov
#
# Release job, only for pushes to the main development branch
Expand Down

0 comments on commit 29eb4ee

Please sign in to comment.