Don't extract getters of objects #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While extracting getters for objects is a nice idea in theory, in practice the whole idea of calling random get* and is* methods on objects can backfire, because we can actually hide, or even worse, accidentally cause calling methods that shouldn't be called in the first place. Fixes mockery#619
This was referenced May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While extracting getters for objects is a nice idea in theory,
in practice the whole idea of calling random get* and is* methods
on objects can backfire, because we can actually hide, or even worse,
accidentally cause calling methods that shouldn't be called in the
first place.
Fixes #619