New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHPUnit 10.x #1219
Draft
ghostwriter
wants to merge
44
commits into
mockery:2.0.x
Choose a base branch
from
ghostwriter:feature/support-phpunit-10
base: 2.0.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support PHPUnit 10.x #1219
ghostwriter
wants to merge
44
commits into
mockery:2.0.x
from
ghostwriter:feature/support-phpunit-10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
ghostwriter
force-pushed
the
feature/support-phpunit-10
branch
from
April 23, 2023 03:22
376033c
to
ac4e632
Compare
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
ghostwriter
changed the title
RFC: Mockery v2.0 with Support
Support Apr 30, 2023
PHPUnit >=10.1
and Drop PHP <8.1
PHPUnit >=10.1
and Drop PHP <8.1
ghostwriter
added
Major
Backwards Incompatible changes
Removed
for features or functionality that have been removed in this release
labels
Apr 30, 2023
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Closed
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
ghostwriter
added
dependencies
Pull requests that update a dependency file
Added
for new features or functionality
labels
May 1, 2023
ghostwriter
changed the title
Support
Support PHPUnit 10.1 and higher
May 4, 2023
PHPUnit >=10.1
and Drop PHP <8.1
ghostwriter
removed
the
Removed
for features or functionality that have been removed in this release
label
May 9, 2023
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
simPod
reviewed
Feb 7, 2024
@@ -34,12 +34,12 @@ | |||
"ext-pcre": "*" | |||
}, | |||
"require-dev": { | |||
"phpunit/phpunit": "^8.5 || ^9.6", | |||
"phpunit/phpunit": "^10.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"phpunit/phpunit": "^10.1", | |
"phpunit/phpunit": "^10.1 || ^11", |
should we add v11 as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Added
for new features or functionality
dependencies
Pull requests that update a dependency file
Major
Backwards Incompatible changes
RFC
proposal for a larger change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @davedevelopment, (and contributors)
currently working on a
Mockery Extension
for PHPUnit 10 (which explicitly requiresPHP 8.1
).Mockery needs to do a few things:
MockeryExceptionInterface
as a"Failure Type"
(to be implemented by allMockery
Exception classes)Exclude Mockery Directory via
PHPUnit\Util\ExcludeList::addDirectory
Add expectations to be verified via
TestCase::addToAssertionCount(Mockery::getContainer()->mockery_getExpectationCount());
before the test starts.Verify expectations after the test has finished (checks if
Mockery::close()
has been called, and let the test fail if it hasn't.)How does it work:
\Mockery\Adapter\Phpunit\Extension
class inphpunit.xml
orphpunit.xml.dist
.\Mockery\Adapter\Phpunit\MockeryTestCase
class in your tests.Deprecated and removed features:
TestListener
Testcase::markAsRisky()
Do we have any plans to drop support for older versions of PHP?
PHPUnit 10
usesPHP 8.1
features (eg.never
return type declarations which would fail on older versions of PHP.)Should we follow, a similar path as PHPUnit and raise the minimum required version of PHP to 8.1 for Mockery v2?
What's our desired version path for adding
Mockery Extension
forPHPUnit 10
:should we resurrect Mockery 2.0 discussion?