Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mockery::fetchMock() without initialized container (1.3 branch) #1114

Merged
merged 1 commit into from Jan 26, 2021

Conversation

PhrozenByte
Copy link
Contributor

See #1113

Calling Mockery::fetchMock() first doesn't make much sense and likely indicates a logic error, but Mockery should nevertheless throw Call to a member function fetchMock() on null errors.

Maybe we should throw a LogicException instead when no container was initialized yet (just like Mockery::self())? If no container was initialized yet, Mockery::fetchMock() will always return null, just like if the mock in question simply doesn't exist (yet). Other opinions?

@davedevelopment
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants