Stop testing with '--prefer-lowest' #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
suggested changes
Dec 8, 2020
LeSuisse
force-pushed
the
stop-testing-lowest-dep
branch
from
c2514f1
to
d87f7ef
Compare
This solve issues with PHPUnit and Xdebug 3.0 for PHP 7.3 and 7.4. mockery has basically no dependencies so the part of the matrix testing with '--prefer-lowest' brings little/no value.
LeSuisse
force-pushed
the
stop-testing-lowest-dep
branch
from
d87f7ef
to
289474a
Compare
|
Would you like that I open the equivalent PR for the |
|
@LeSuisse Sure, will save me a job thank you 👍 |
|
Usually what I do is an actual merge 1.3 -> master, so the commit history is retained. We can probably hold off merging upwards until the other upcoming 1.3 PR lands. |
|
Sorry, forgot we had the other one, all merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solve issues with PHPUnit and Xdebug 3.0 when running tests for PHP 7.3 and 7.4.
mockery has basically no dependencies so the part of the matrix testing with '--prefer-lowest' brings little/no value.
See the discussion in #1106 (comment)