Fix: array to string conversion in ConstantsPass [master] #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this bug in 1.3.x too? I think we should fix everything which can be reasonable fixed on there, and merge upwards. |
|
@GrahamCampbell in 1.3.x and 1.2.x too. |
|
Don't worry about 1.2.x, but if you could target 1.3.x, assuming @davedevelopment is happy with that, I think that'd be best. :) |
MPC-khajiit
changed the title
|
I\m a bit confused. This PR has actually already been applied to the code. Why is it being sent again? |
|
@davedevelopment This can be closed I think? |
|
@GrahamCampbell @davedevelopment i'm closing it because previously i prepared two PR (for master and for 1.3 aka #1086) and was merged also into master. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1084