Remove comments from mock pass #1030
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new string manipulation pass that removes all code comments and empty lines from the generated mock code, so that the other string manipulation passes have less code to work on.
Given that the str_replace has to happen on substrings that are before the first curly bracket, split the generated mock code by the first curly bracket, and then do the str_replace only on that smaller chunk of code. Not sure if there's really any benefit to this, as we're replacing one string operation with another one.
|
I doubt there's better performance. Do you have any evidence? I actually suspect this is slower, because you have to do work to remove the comments Also, stripping phpdoc can be dangerous, because phpdoc can have semantic meaning, such as in doctrine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the memory leak issues, I've noticed that Mockery is doing a bit more work than really necessary. The Mock class is full of docblocks and comments that increase the generated code, meaning the string manipulation passes need more memory.
I'm not really sure about this approach. I've also learned that php has
-wswitch that strips away all comments and whitespace and creates output that can be used instead of Mock.php. The problem with that approach though, that we should be generating that file ourselves for every release (probably can be automated, but still, it's a step that can go wrong.) This StrippedMock.php has better performance impacts than the changes from this MR.Thoughts?