andReturnArgument #1001
andReturnArgument #1001
Conversation
|
Resolves #992 |
library/Mockery/Expectation.php
Outdated
| if (isset($args[$index])) { | ||
| return $args[$index]; | ||
| } | ||
| throw new Exception("Cannot return an argument value. No argument exists for the index $index"); |
There was a problem hiding this comment.
I'm not 100% sure if throwing an exception here is correct.
What do people think is the right behaviour when the argument index is out-of-bounds for a particular method call?
There was a problem hiding this comment.
I think it's a reasonable starting point. Could throw a OutOfBoundsException to be more explicit.
library/Mockery/Expectation.php
Outdated
| throw new \InvalidArgumentException("Invalid argument index supplied. Index must be a positive integer."); | ||
| } | ||
| $closure = function (...$args) use ($index) { | ||
| if (isset($args[$index])) { |
There was a problem hiding this comment.
Probably want array_key_exists here, the argument could legitimately be null. Test case to cover would be good too.
There was a problem hiding this comment.
Good catch, I'll update both
library/Mockery/Expectation.php
Outdated
| * @param int $index | ||
| * @return self | ||
| */ | ||
| public function andReturnArgument($index) |
There was a problem hiding this comment.
I'm not 100% sure what would be best, but in other public methods, we use withArgs, rather than withArguments.
So would we better with andReturnArg or is Arg too ambiguous?
There was a problem hiding this comment.
I think andReturnArg is fine; I'm happy to keep things consistent.
|
Sorry for the delay! Missed the notification on this one. |
|
No worries, thanks for the review |
|
@davedevelopment I've updated this MR according to your feedback |
|
Thank you, great stuff |
Added functionality to return an argument passed to a method expectation