Skip to content

Commit

Permalink
Merge pull request #1162 from KDederichs/fix_1153
Browse files Browse the repository at this point in the history
Add __toString to array of methods to be removed in pass
  • Loading branch information
davedevelopment committed Apr 12, 2022
2 parents c10a5f6 + 2a90223 commit 6439fe5
Show file tree
Hide file tree
Showing 2 changed files with 95 additions and 0 deletions.
Expand Up @@ -32,6 +32,7 @@ class RemoveBuiltinMethodsThatAreFinalPass
{
protected $methods = array(
'__wakeup' => '/public function __wakeup\(\)\s+\{.*?\}/sm',
'__toString' => '/public function __toString\(\)\s+(:\s+string)?\s*\{.*?\}/sm',
);

public function apply($code, MockConfiguration $config)
Expand Down
94 changes: 94 additions & 0 deletions tests/Mockery/MockClassWithFinalToStringTest.php
@@ -0,0 +1,94 @@
<?php
/**
* Mockery
*
* LICENSE
*
* This source file is subject to the new BSD license that is bundled
* with this package in the file LICENSE.txt.
* It is also available through the world-wide-web at this URL:
* http://github.com/padraic/mockery/master/LICENSE
* If you did not receive a copy of the license and are unable to
* obtain it through the world-wide-web, please send an email
* to padraic@php.net so we can send you a copy immediately.
*
* @category Mockery
* @package Mockery
* @subpackage UnitTests
* @copyright Copyright (c) 2012 Philip Graham <philip.robert.graham@gmail.com>
* @license http://github.com/padraic/mockery/blob/master/LICENSE New BSD License
*/

namespace test\Mockery;

use Mockery\Adapter\Phpunit\MockeryTestCase;

class MockClassWithFinalToStringTest extends MockeryTestCase
{
protected function mockeryTestSetUp()
{
$this->container = new \Mockery\Container();
}

protected function mockeryTestTearDown()
{
$this->container->mockery_close();
}

/**
* @test
*
* Test that we are able to create partial mocks of classes that have
* a __wakeup method marked as final. As long as __wakeup is not one of the
* mocked methods.
*/
public function testCreateMockForClassWithFinalToString()
{
$mock = $this->container->mock("test\Mockery\TestWithFinalToString");
$this->assertInstanceOf("test\Mockery\TestWithFinalToString", $mock);
$this->assertEquals('test\Mockery\TestWithFinalToString::__toString', $mock->__toString());

$mock = $this->container->mock('test\Mockery\SubclassWithFinalToString');
$this->assertInstanceOf('test\Mockery\TestWithFinalToString', $mock);
$this->assertEquals('test\Mockery\TestWithFinalToString::__toString', $mock->__toString());
}

public function testCreateMockForClassWithNonFinalToString()
{
$mock = $this->container->mock('test\Mockery\TestWithNonFinalToString');
$this->assertInstanceOf('test\Mockery\TestWithNonFinalToString', $mock);

// Make sure __toString is overridden.
$this->assertNotEquals('bar', $mock->__toString());
}
}

class TestWithFinalToString
{
public function foo()
{
return 'foo';
}

public function bar()
{
return 'bar';
}

final public function __toString()
{
return __METHOD__;
}
}

class SubclassWithFinalToString extends TestWithFinalToString
{
}

class TestWithNonFinalToString
{
public function __toString()
{
return 'bar';
}
}

0 comments on commit 6439fe5

Please sign in to comment.