Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into adding Knip #5042

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Look into adding Knip #5042

wants to merge 5 commits into from

Conversation

voxpelli
Copy link
Member

@voxpelli voxpelli commented Dec 5, 2023

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Alternate Designs

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

@voxpelli
Copy link
Member Author

voxpelli commented Dec 5, 2023

Thoughts:

That leaves this PR doing only knip, which is good, and we can rebase it until it passes and when it passes we can merge it 🎉

@voxpelli
Copy link
Member Author

voxpelli commented Dec 5, 2023

Still eg. complains on:

@11ty/eleventy         package.json
@mocha/docdash         package.json
assetgraph-builder     package.json
autoprefixer           package.json
canvas                 package.json
coffeescript           package.json
coveralls              package.json
eslint-plugin-node     package.json
husky                  package.json
hyperlink              package.json
jsdoc                  package.json
jsdoc-ts-utils         package.json
karma-chrome-launcher  package.json
karma-sauce-launcher   package.json
markdown-toc           package.json
needle                 package.json
nyc                    package.json
strip-ansi             package.json
svgo                   package.json
update-notifier        package.json
webpack-cli            package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author waiting on response from OP - more information needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants