Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devDeps: remove 'cross-spawn' #4779

Merged
merged 1 commit into from Oct 29, 2021
Merged

devDeps: remove 'cross-spawn' #4779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
149 changes: 100 additions & 49 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -97,7 +97,6 @@
"core-js": "^3.16.3",
"coveralls": "^3.1.1",
"cross-env": "^7.0.2",
"cross-spawn": "^7.0.3",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
"eslint-config-semistandard": "^16.0.0",
Expand Down
12 changes: 6 additions & 6 deletions test/integration/helpers.js
View file
Open in desktop
Expand Up @@ -297,7 +297,7 @@ function invokeNode(args, done, opts = {}) {
*
* @param {string[]} args - Path to executable and arguments
* @param {RawResultCallback} done - Callback
* @param {Object|string} [opts] - Options to `cross-spawn` or `child_process.fork` or 'pipe' for shortcut to `{stdio: pipe}`
* @param {Object|string} [opts] - Options to `child_process` or 'pipe' for shortcut to `{stdio: pipe}`
* @param {boolean} [opts.fork] - If `true`, use `child_process.fork` instead
* @returns {import('child_process').ChildProcess}
*/
Expand Down Expand Up @@ -334,7 +334,7 @@ function createSubprocess(args, done, opts = {}) {
debug('forking: %s', args.join(' '));
mocha = fork(args[0], args.slice(1), opts);
} else {
const {spawn} = require('cross-spawn');
const {spawn} = require('child_process');
debug('spawning: %s', [process.execPath].concat(args).join(' '));
mocha = spawn(process.execPath, args, opts);
}
Expand Down Expand Up @@ -400,11 +400,11 @@ function getSummary(res) {
* and waits until the second test run has been completed. Mocha is
* killed and the result is returned.
*
* On Windows, this will call `child_process.fork()` instead of `cross-spawn.spawn()`.
* On Windows, this will call `child_process.fork()` instead of `spawn()`.
*
* **Exit code will always be 0**
* @param {string[]} args - Array of argument strings
* @param {object|string} opts - If a `string`, then `cwd`, otherwise options for `cross-spawn.spawn` or `child_process.fork`
* @param {object|string} opts - If a `string`, then `cwd`, otherwise options for `child_process`
* @param {Function} change - A potentially `Promise`-returning callback to execute which will change a watched file
* @returns {Promise<RawResult>}
*/
Expand Down Expand Up @@ -451,11 +451,11 @@ async function runMochaWatchAsync(args, opts, change) {
* and waits until the second test run has been completed. Mocha is
* killed and the result is returned.
*
* On Windows, this will call `child_process.fork()` instead of `cross-spawn.spawn()`.
* On Windows, this will call `child_process.fork()` instead of `spawn()`.
*
* **Exit code will always be 0**
* @param {string[]} args - Array of argument strings
* @param {object|string} opts - If a `string`, then `cwd`, otherwise options for `cross-spawn.spawn` or `child_process.fork`
* @param {object|string} opts - If a `string`, then `cwd`, otherwise options for `child_process`
* @param {Function} change - A potentially `Promise`-returning callback to execute which will change a watched file
* @returns {Promise<JSONResult>}
*/
Expand Down