Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node v17 into ci matrix #4777

Merged
merged 3 commits into from Oct 27, 2021
Merged

Add Node v17 into ci matrix #4777

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab05d5d
ci: add node 17 to build matrix
outsideris Oct 25, 2021
c471081
ci: add node 17 to build matrix
outsideris Oct 27, 2021
d331adb
ci: use node v16 as default version
outsideris Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/mocha.yml
View file
Open in desktop
Expand Up @@ -32,6 +32,7 @@ jobs:
- 12
- 14
- 16
- 17
juergba marked this conversation as resolved.
Show resolved Hide resolved
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
Expand All @@ -47,15 +48,15 @@ jobs:
steps:
- uses: actions/setup-node@v2
with:
node-version: 14
node-version: 16
- uses: actions/checkout@v2
- name: 'Cache node_modules'
uses: actions/cache@v2
with:
path: '~/.npm'
key: "ubuntu-latest-node-v14-${{ hashFiles('**/package-lock.json') }}"
key: "ubuntu-latest-node-v16-${{ hashFiles('**/package-lock.json') }}"
restore-keys: |
ubuntu-latest-node-v14-
ubuntu-latest-node-v16-
- name: Install Dependencies
run: npm ci --ignore-scripts
- name: 'Check lint'
Expand All @@ -76,9 +77,10 @@ jobs:
- 12
- 14
- 16
- 17
include:
- os: ubuntu-latest
node: 14
node: 16
env:
COVERAGE: 1
steps:
Expand Down Expand Up @@ -181,17 +183,17 @@ jobs:
steps:
- uses: actions/setup-node@v2
with:
node-version: 14
node-version: 16
- uses: actions/checkout@v2
- name: 'Cache node_modules'
uses: actions/cache@v2
with:
path: '~/.npm'
# this key is different than above, since we are running scripts
# (builds, postinstall lifecycle hooks, etc.)
key: "ubuntu-latest-node-full-v14-${{ hashFiles('**/package-lock.json') }}"
key: "ubuntu-latest-node-full-v16-${{ hashFiles('**/package-lock.json') }}"
restore-keys: |
ubuntu-latest-node-full-v14-
ubuntu-latest-node-full-v16-
- name: Install Dependencies
run: npm ci
- name: Run Browser Tests
Expand Down