Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build UMD bundle and polyfill language features #4366

Merged
merged 12 commits into from Jul 28, 2020
Merged

build UMD bundle and polyfill language features #4366

merged 12 commits into from Jul 28, 2020

Commits on Jul 17, 2020

  1. build a UMD bundle instead of IIFE 

    - remove old ESlint rule to disallow `Object.assign`
- consume Rollup config's `output` prop in `karma-rollup-plugin`
- simplify `rollup.config.js` `output` prop
- fix invalid `script` tag `src` attrib in `lib/browser/template.html` (& reformat)
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    d6694f4 View commit details
    Browse the repository at this point in the history

  2. fix broken tests 

    - fix broken bundle output path
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    f112e19 View commit details
    Browse the repository at this point in the history

  3. add a proper RequireJS integration test 

    - remove the old `bundle/amd.spec.js` test
- _actually_ fix bundle output file path
- fix a typo in karma rollup plugin
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    8db4996 View commit details
    Browse the repository at this point in the history

  4. fix travis script 

    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    cabb0ab View commit details
    Browse the repository at this point in the history

  5. use core-js polyfills

    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    b9aebeb View commit details
    Browse the repository at this point in the history

  6. remove regenerator-runtime; copy/paste config from stackoverflow 

    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    8a07559 View commit details
    Browse the repository at this point in the history

  7. update Symbol test for IE11 

    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    556cbc1 View commit details
    Browse the repository at this point in the history

  8. revert change to Symbol-in-object test 

    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    6486f05 View commit details
    Browse the repository at this point in the history

  9. tweak assertion AGAIN for Symbol 

    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    fe7227e View commit details
    Browse the repository at this point in the history

  10. merge fixes

    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    9cd9e23 View commit details
    Browse the repository at this point in the history

  11. try to make karma.conf.js less indimidating 

    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    66369b4 View commit details
    Browse the repository at this point in the history

  12. allow custom externals/globals in karma rollup plugin 

    - `unexpected`, `unexpected-eventemitter`, and `unexpected-sinon` are now external (not bundled) and loaded via their globals
- modified `test/browser-specific/setup.js` to use `require()` since we can do that now
- bundle now has an inline source map since I couldn't figure out any other way to load it
- removed duplication of work in the karma plugin; no call to `bundle.generate()` is needed. furthermore the `code` prop did not include the inline source maps. so we just write the file and read the result. could probably avoid reading the file by manually stitching the `code` and `map` props together, but I'm unsure how
- loads `mocha.js.map`
    @boneskull
    boneskull committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    2cf235b View commit details
    Browse the repository at this point in the history