Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vulnerabilty): switch tiny dependency and use same code #4336

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ The obligatory patch after a major.

## :bug: Fixes

- [#4332](https://github.com/mochajs/mocha/issues/4332): Replace `yargs-unparser` with `@care-for/yargs-unparser` to fix lodash vulnarability ([**@martinoppitz**](https://github.com/martinoppitz))
- [#4331](https://github.com/mochajs/mocha/issues/4331): Update `serialize-javascript` to 3.1.0 ([**@martinoppitz**](https://github.com/martinoppitz))
- [#4328](https://github.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://github.com/boneskull))

# 8.0.0 / 2020-06-10
Expand Down
2 changes: 1 addition & 1 deletion bin/mocha
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const {
isNodeFlag,
impliesNoTimeouts
} = require('../lib/cli/node-flags');
const unparse = require('yargs-unparser');
const unparse = require('@care-for/yargs-unparser');
const debug = require('debug')('mocha:cli:mocha');
const {aliases} = require('../lib/cli/run-option-metadata');

Expand Down
2 changes: 1 addition & 1 deletion lib/cli/node-flags.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

const nodeFlags = process.allowedNodeEnvironmentFlags;
const unparse = require('yargs-unparser');
const unparse = require('@care-for/yargs-unparser');

/**
* These flags are considered "debug" flags.
Expand Down
126 changes: 108 additions & 18 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"version": "nps version"
},
"dependencies": {
"@care-for/yargs-unparser": "1.6.1",
"ansi-colors": "4.1.1",
"browser-stdout": "1.3.1",
"chokidar": "3.3.1",
Expand All @@ -74,8 +75,7 @@
"wide-align": "1.1.3",
"workerpool": "6.0.0",
"yargs": "13.3.2",
"yargs-parser": "13.1.2",
"yargs-unparser": "1.6.0"
"yargs-parser": "13.1.2"
},
"devDependencies": {
"@11ty/eleventy": "^0.10.0",
Expand Down