Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix improper warnings for invalid reporters #4275

Merged
merged 3 commits into from May 14, 2020
Merged

fix improper warnings for invalid reporters #4275

merged 3 commits into from May 14, 2020

Commits on May 14, 2020

  1. fix improper warnings for invalid reporters 

    also: reorganize, add, and refactor a bunch of problematic unit tests for `lib/mocha.js`.  better isolation except where we can't really do that (calling `require`)

there's still missing tests in here, but this is an improvement.
    @boneskull
    boneskull committed May 14, 2020
    Copy the full SHA
    5b7798a View commit details
    Browse the repository at this point in the history

  2. restrict use of Object.assign

    @boneskull
    boneskull committed May 14, 2020
    Copy the full SHA
    4f01095 View commit details
    Browse the repository at this point in the history

  3. add wrapper around process.cwd() 

    - better isolation
- a use of `process.cwd()` in `lib/runner.js` was left in place to avoid conflicts, because another PR will remove it
    @boneskull
    boneskull committed May 14, 2020
    Copy the full SHA
    0bd7e14 View commit details
    Browse the repository at this point in the history