Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes some signal handling #4239

Merged
merged 1 commit into from Apr 24, 2020
Merged

fixes some signal handling #4239

merged 1 commit into from Apr 24, 2020

Conversation

boneskull
Copy link
Member

  • landing reporter befouls the terminal up if SIGINT is issued
  • --exit test used an incorrect description, and also did not reliably handle SIGINT when running

Ref: #4198

@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 21, 2020
@boneskull boneskull self-assigned this Apr 21, 2020
@boneskull boneskull mentioned this pull request Apr 21, 2020
Closed
22 tasks
@boneskull
Copy link
Member Author

boneskull commented Apr 22, 2020 •
edited

I think this needs changes from #4245

@boneskull
Copy link
Member Author

I'm going to close this one and add it to #4245.

@boneskull boneskull closed this Apr 22, 2020
@boneskull boneskull reopened this Apr 22, 2020
@boneskull
Copy link
Member Author

ah, nm, I see the issue.

@boneskull
fixes some signal handling
7496f93 
- `landing` reporter befouls the terminal up if `SIGINT` is issued
- `--exit` test used an incorrect description, and also did not reliably handle `SIGINT` when running
- `runMocha` helper returns the child process

Ref: #4198
@boneskull boneskull force-pushed the boneskull/issue/2839-signal-fixes branch from d2f29a2 to 7496f93 Compare April 22, 2020 21:44
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 92.967% when pulling 7496f93 on boneskull/issue/2839-signal-fixes into 6838eaf on master.

@boneskull
Copy link
Member Author

I don't have any idea how we could test the newly-uncovered lines (in the landing reporter). we'll have to deal with the 0.09% decrease in coverage.

@boneskull
Copy link
Member Author

cc @arvidOtt and/or @raymondfeng

this is short and low-impact, but would appreciate anybody taking a look.

craigtaub
craigtaub approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@craigtaub craigtaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it would register "SIGINT" but the cursor would remain hidden? Not good. Good fix 👍

@boneskull
Copy link
Member Author

So it would register "SIGINT" but the cursor would remain hidden? Not good. Good fix 👍

Not quite. What was happening was if someone was using the landing reporter and issued a SIGINT (via ctrl-C or whatever) while the cursor was hidden (which it is for much of the reporter), it would not restore the cursor to the user's terminal. annoying

@boneskull boneskull merged commit 284b411 into master Apr 24, 2020
@craigtaub craigtaub added this to the next milestone May 21, 2020
@juergba juergba deleted the boneskull/issue/2839-signal-fixes branch January 29, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigtaub craigtaub craigtaub approved these changes

@arvidOtt arvidOtt arvidOtt approved these changes

@juergba juergba Awaiting requested review from juergba

@Munter Munter Awaiting requested review from Munter

@outsideris outsideris Awaiting requested review from outsideris

@giltayar giltayar Awaiting requested review from giltayar

Assignees

@boneskull boneskull

Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boneskull @coveralls @craigtaub @arvidOtt