Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple async done() calls result in failure; closes #4151 #4152

Merged
merged 5 commits into from May 20, 2020

Commits on May 19, 2020

  1. multiple async done() calls result in failure; closes #4151

    - added a method in `errors` module to create a "multiple done" err
    - modernize `multiple-done.spec.js`
    - refactor errors into constants in `errors` module
    - remove `Runner#started` prop; replace with `Runner#state` prop + constants
    - add a catchall `createFatalError()` function to `errors` module; this is called
      when a test fails twice by other means (unsure what those means are yet)
    - force color in Travis CI b/c my eyes
    boneskull committed May 19, 2020
    Copy the full SHA
    db4f885 View commit details
    Browse the repository at this point in the history
  2. remove Runner#uncaughtEnd

    move logic to `Runner#uncaught`, since we can now rely on the value of `Runner#state`.
    
    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    boneskull committed May 19, 2020
    Copy the full SHA
    cf66f00 View commit details
    Browse the repository at this point in the history
  3. upgrade unexpected-eventemitter

    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    boneskull committed May 19, 2020
    Copy the full SHA
    770659d View commit details
    Browse the repository at this point in the history
  4. fix test

    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    boneskull committed May 19, 2020
    Copy the full SHA
    55283e3 View commit details
    Browse the repository at this point in the history
  5. fix potential listener leak

    Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
    boneskull committed May 19, 2020
    Copy the full SHA
    7b39f4c View commit details
    Browse the repository at this point in the history