Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: control stringification of error message #4128

Merged
merged 4 commits into from May 28, 2021
Merged

Fix: control stringification of error message #4128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3facdf
fix inspect order error and add util inspect custom function
Dec 14, 2019
4beb8f0
Add test code for handling error inspect
Dec 14, 2019
bec18a9
Remove util.inspect.custom API
Dec 14, 2019
3b7edd9
Fix comment
May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/reporters/base.js
View file
Open in desktop
Expand Up @@ -236,10 +236,10 @@ exports.list = function(failures) {
err = test.err;
}
var message;
if (err.message && typeof err.message.toString === 'function') {
message = err.message + '';
} else if (typeof err.inspect === 'function') {
if (typeof err.inspect === 'function') {
message = err.inspect() + '';
} else if (err.message && typeof err.message.toString === 'function') {
message = err.message + '';
} else {
message = '';
}
Expand Down
18 changes: 10 additions & 8 deletions test/reporters/base.spec.js
View file
Open in desktop
Expand Up @@ -366,22 +366,24 @@ describe('Base reporter', function() {
expect(errOut, 'to be', '1) test title:\n Error\n foo\n bar');
});

it("should use 'inspect' if 'message' is not set", function() {
var err = {
showDiff: false,
inspect: function() {
return 'an error happened';
}
it("should use 'inspect' if 'inspect' and 'message' are set", function() {
var err = new Error('test');
err.showDiff = false;
err.message = 'error message';
err.inspect = function() {
syeutyu marked this conversation as resolved.
Show resolved Hide resolved
return 'Inspect Error';
};

var test = makeTest(err);

list([test]);

var errOut = stdout.join('\n').trim();
expect(errOut, 'to be', '1) test title:\n an error happened');

expect(errOut, 'to contain', 'Inspect Error');
});

it("should set an empty message if neither 'message' nor 'inspect' is set", function() {
it("should set an empty message if neither 'inspect' nor 'message' is set", function() {
var err = {
showDiff: false
};
Expand Down