Support util.inspect.custom with fixing #3985 #4085
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
There are two sub issues in the issue #3985
lib/reporters/base.js
1 - message
2 - inspect()
3 - empty string
1 - inspect()
2 - message
3 - empty string
util.inspect.custom()
, which seems standard of nodejs for representing an object for debugging purpose, and use it first when generating an error message. (https://nodejs.org/api/util.html#util_util_inspect_custom)This PR resolves those issues.
Benefits
Making developers have more autonomy when they make error message.
Possible Drawbacks
Fragmentation of a way to generate error message.
I think we can take it because
util.inspect.custom
is general way to make representative string of object.But hope no fragmentation anymore.